This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Simplify Commit List sorting logic #8365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
approved these changes
Apr 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8365 +/- ##
===============================================
- Coverage 83.21% 83.21% -0.01%
===============================================
Files 592 592
Lines 22192 22188 -4
Branches 3249 3244 -5
===============================================
- Hits 18468 18464 -4
Misses 3724 3724
|
mosmartin
approved these changes
Apr 17, 2023
bobanm
force-pushed
the
8364-commit-list-sort
branch
from
ad0b65e
to
8c8c407
Compare
shuse2
approved these changes
Apr 17, 2023
mosmartin
approved these changes
Apr 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8364
How was it solved?
ascendingHeightargument tosortOrderCOMMIT_SORTconstants, and used it to pass tosort()function callback, instead of using a conditional for checking the sort order.CommitPool._getAllCommits()no longer takes or passes sorting arguments, as it always uses ascending order, which is the default forCommitList.getAll()CommitList.deleteByHeight()BONUS: Tidied up the comments order and code block spacing in
CommitPoolclass 😎How was it tested?
All unit tests pass 👌🏻